Skip to content

Conversation

asomers
Copy link
Contributor

@asomers asomers commented Jun 14, 2025

A recent change has replaced an unused preprocessor symbol: P_UNUSED3

freebsd/freebsd-src@33be163

Another recent change has changed the size of a spare field: mc_spare

freebsd/freebsd-src@eea3e4d

Description

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, CI will fail until #4489. Are you okay to backport this as well?

@asomers
Copy link
Contributor Author

asomers commented Jun 15, 2025

Backport to the 0.2 branch? Yes, that would be good.

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Jun 15, 2025
@tgross35 tgross35 enabled auto-merge June 15, 2025 23:47
@tgross35 tgross35 disabled auto-merge June 16, 2025 00:05
@tgross35
Copy link
Contributor

I have absolutely no idea why small changes like this make ctest blow up, that library is insufferable and I can't wait until it's gone. I'm going to try to get things "fixed" a bit more before merging this so we don't lose all the FreeBSD CI jobs (#4469)

@tgross35 tgross35 force-pushed the fbsd15-june-2025 branch from 86f0913 to 650b7fb Compare July 7, 2025 21:04
A recent change has replaced an unused preprocessor symbol: P_UNUSED3

freebsd/freebsd-src@33be163

Another recent change has changed the size of a spare field: mc_spare

freebsd/freebsd-src@eea3e4d
@tgross35 tgross35 force-pushed the fbsd15-june-2025 branch from 650b7fb to 46b90a8 Compare July 7, 2025 21:23
@tgross35
Copy link
Contributor

tgross35 commented Jul 7, 2025

I still can't explain why ctest seems to work so poorly on FreeBSD, but it seems bimodal. I think we may as well get this in and try to poke things further from there.

We should have the new ctest in another couple of weeks anyway.

@tgross35 tgross35 enabled auto-merge July 7, 2025 21:27
@tgross35 tgross35 added this pull request to the merge queue Jul 7, 2025
Merged via the queue into rust-lang:main with commit 89e0ff1 Jul 7, 2025
73 of 79 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Jul 29, 2025
A recent change has replaced an unused preprocessor symbol: P_UNUSED3

freebsd/freebsd-src@33be163

Another recent change has changed the size of a spare field: mc_spare

freebsd/freebsd-src@eea3e4d

(backport <rust-lang#4488>)
(cherry picked from commit 46b90a8)
@tgross35 tgross35 mentioned this pull request Jul 29, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jul 29, 2025
A recent change has replaced an unused preprocessor symbol: P_UNUSED3

freebsd/freebsd-src@33be163

Another recent change has changed the size of a spare field: mc_spare

freebsd/freebsd-src@eea3e4d

(backport <#4488>)
(cherry picked from commit 46b90a8)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-unix O-x86 stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants